Skip to content

Feature/use rectools lightfm#165

Merged
feldlime merged 5 commits intomainfrom
feature/use_rectools_lightfm
Jul 25, 2024
Merged

Feature/use rectools lightfm#165
feldlime merged 5 commits intomainfrom
feature/use_rectools_lightfm

Conversation

@feldlime
Copy link
Copy Markdown
Collaborator

@feldlime feldlime commented Jul 24, 2024

Description

  • Used rectools-lightfm package instead of original lightfm

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@feldlime feldlime requested a review from blondered July 24, 2024 18:47
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (a040eba).
Report is 68 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #165     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        55     +10     
  Lines         2242      3304   +1062     
===========================================
+ Hits          2242      3304   +1062     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime feldlime merged commit db27460 into main Jul 25, 2024
@feldlime feldlime deleted the feature/use_rectools_lightfm branch July 25, 2024 06:49
blondered pushed a commit that referenced this pull request Sep 23, 2024
- Used `rectools-lightfm` package instead of original `lightfm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants