Removed internal ids usage outside models#177
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 56 +11
Lines 2242 3451 +1209
===========================================
+ Hits 2242 3451 +1209 ☔ View full report in Codecov by Sentry. |
added 2 commits
August 12, 2024 15:08
…into feature/no_internal_ids
feldlime
reviewed
Aug 12, 2024
feldlime
reviewed
Aug 13, 2024
feldlime
approved these changes
Aug 15, 2024
blondered
added a commit
that referenced
this pull request
Sep 23, 2024
- Removed `assume_external_ids` parameter in `recommend` and `recommend_to_items` model methods - Added `on_unsupported_targets` in `recommend` and `recommend_to_items` model methods - Added `filter_on_interactions_df_row_indexes` method of `Dataset` - Fixed `IntraListDiversity` metric computation in `cross_validate`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assume_external_idsparameter inrecommendandrecommend_to_itemsmodel methodson_unsupported_targetsinrecommendandrecommend_to_itemsmodel methodsfilter_on_interactions_df_row_indexesmethod ofDatasetIntraListDiversitymetric computation incross_validate