Skip to content

[DOP-31839] Add job tags#367

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-31839
Jan 21, 2026
Merged

[DOP-31839] Add job tags#367
dolfinus merged 1 commit intodevelopfrom
feature/DOP-31839

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Jan 21, 2026

Change Summary

Mostly a copy-paste of dataset tags:

  • Added job_tag table
  • Added tags: list field into JobDetailedResponse schema
  • Added filter tag_value_id: list[int] into GET /v1/jobs endpoint

Extra changes:

  • Renamed table dataset_tags to dataset_tag, as all table names in this repo are singular
  • Dropped unused datasets_with_tags fixture
  • Replaced dataset_with_tags and create_dataset_with_tags with make_dataset+tag_values fixture

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jan 21, 2026
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
data_rentgen/db/migrations/versions
   2026-01-21_675ed36b7807_add_job_tag.py990%11–12, 15–18, 21–22, 32
   2026-01-21_f1c76c422433_rename_table_dataset_tags_to_dataset_tag.py880%11, 14–17, 20–22
data_rentgen/db/repositories
   job.py76396%183, 207–208
data_rentgen/server/services
   dataset.py27196%36
   job.py30196%37
   location.py51198%58
   operation.py41197%56
TOTAL726392187% 

@dolfinus dolfinus marked this pull request as ready for review January 21, 2026 12:01
@dolfinus dolfinus merged commit 932423d into develop Jan 21, 2026
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-31839 branch January 21, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants