[DOP-8140] Split Clickhouse and Clickhouse.Dialect to separated submodules#133
Merged
[DOP-8140] Split Clickhouse and Clickhouse.Dialect to separated submodules#133
Conversation
df9d127 to
7eb02e9
Compare
4b7a97f to
1980642
Compare
Codecov Report
@@ Coverage Diff @@
## develop #133 +/- ##
===========================================
+ Coverage 94.22% 94.29% +0.07%
===========================================
Files 195 207 +12
Lines 7684 7697 +13
Branches 1450 1451 +1
===========================================
+ Hits 7240 7258 +18
+ Misses 324 320 -4
+ Partials 120 119 -1
|
1980642 to
d5d7385
Compare
d5d7385 to
d9bc06c
Compare
d9bc06c to
35339f8
Compare
35339f8 to
444bdd0
Compare
444bdd0 to
150319f
Compare
150319f to
04832cf
Compare
04832cf to
c5479c5
Compare
c5479c5 to
8f59bb8
Compare
dmitry-pedchenko
approved these changes
Aug 22, 2023
8f59bb8 to
3201471
Compare
andy-takker
approved these changes
Aug 23, 2023
3201471 to
721d804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
ClickhouseandClickhouse.Dialectto submodules. Same forMSSQL,MySQL,Oracle,Postgres,Teradata.partitioningMode="hash"and"mod"fromReadOptionstoDialect. Because of this, connection-related classesReadOptionsandOptionsare not required anymore, all JDBC connection uses the sameJDBCOptionsandJDBCLegacyOptions.DBReaderand.sqlwithJDBCReadOptions)DBWriterwithJDBCWriteOptions).fetchand.executewithJDBCOptions)partitioningMode="range"with unsetlowerBound/upperBound, discovered and fixed bug in Oracle dialect - expressionMAX(column) AS maxwas returned as dataframe column with nameMAXinstead ofmax.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)