[DOP-9208] Fix calling .close() method in __del__#156
Merged
Conversation
ac95e58 to
9f973c9
Compare
9f973c9 to
3125394
Compare
Codecov Report
@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
+ Coverage 94.30% 94.41% +0.11%
===========================================
Files 208 208
Lines 7775 7790 +15
Branches 1465 1472 +7
===========================================
+ Hits 7332 7355 +23
+ Misses 322 315 -7
+ Partials 121 120 -1
|
3125394 to
b53a748
Compare
maxim-lixakov
approved these changes
Sep 26, 2023
dmitry-pedchenko
approved these changes
Sep 26, 2023
dmitry-pedchenko
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
self._last_connection_and_optionsinJDBCMixinwithcontextlib.suppressto avoid showing error messages while stopping Python interpreter.self._last_connection_and_optionsthread-local variable. This allows to create separated connections to database in different Python threads, instead of using global connection object..close()method while deletingFileConnectioninstance by garbage collector. Add notes why this should not be used in some other connection classes, like FileDF and Kafka.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)