[DOP-23318] Avoid suppressing Hive Metastore errors#329
Merged
Conversation
d0ac0ad to
ea43968
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
========================================
Coverage 91.84% 91.84%
========================================
Files 227 227
Lines 9784 9790 +6
Branches 998 999 +1
========================================
+ Hits 8986 8992 +6
- Misses 604 606 +2
+ Partials 194 192 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea43968 to
2a6b97c
Compare
IlyasDevelopment
approved these changes
Jan 21, 2025
Co-authored-by: Aleksey Nikoalev <98986158+piece-of-iron@users.noreply.github.com>
fafaf40 to
a087a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Using code like:
could lead to overriding table that really exists, but Hive Metastore returned error because it is overloaded. Replace this with solution which doesn't catch all exceptions.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)