[DOP-23742] Fix writing to Postgres and Greenplum behind PGBouncer#336
Merged
[DOP-23742] Fix writing to Postgres and Greenplum behind PGBouncer#336
Conversation
0dd40db to
573399a
Compare
573399a to
003e57f
Compare
003e57f to
f97b412
Compare
f97b412 to
c7df377
Compare
c7df377 to
e9a728a
Compare
e9a728a to
3cc0bd2
Compare
3cc0bd2 to
a2e3784
Compare
a2e3784 to
a67e424
Compare
a67e424 to
acda8f1
Compare
acda8f1 to
92b7f27
Compare
92b7f27 to
5618df1
Compare
5618df1 to
0b00e32
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #336 +/- ##
===========================================
+ Coverage 91.89% 92.02% +0.12%
===========================================
Files 228 228
Lines 9836 9840 +4
Branches 1008 1008
===========================================
+ Hits 9039 9055 +16
+ Misses 605 598 -7
+ Partials 192 187 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/tests_integration/tests_db_connection_integration/test_postgres_integration.py
Outdated
Show resolved
Hide resolved
IlyasDevelopment
approved these changes
Feb 6, 2025
0b00e32 to
6fb3cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Depends on #337.
Fixed issue with writing data to PG/GP instances behind pgbouncer with
pool_mode=transaction, caused by pgjdbc/pgjdbc#848. Added PGBouncer to docker-compose and CI workflows, running tests on PG/GP with and without PGBouncer.Behavior is almost the same as before, except rare case of Postgres/Greenplum calling
connection.fetch("SELECT function()")wherefunctioncalls DML/DDL - previously this failed due to read-only connection, now it's not. This was sacrificed for pgbounce support.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)