[DOP-23969] Fix Greenplum parallel connections warning for master=local[N]#342
Merged
[DOP-23969] Fix Greenplum parallel connections warning for master=local[N]#342
Conversation
8b0c1a3 to
4709234
Compare
4709234 to
462e317
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #342 +/- ##
===========================================
+ Coverage 92.02% 92.33% +0.31%
===========================================
Files 228 228
Lines 9867 9875 +8
Branches 1013 1013
===========================================
+ Hits 9080 9118 +38
+ Misses 599 566 -33
- Partials 188 191 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
462e317 to
f079ee2
Compare
IlyasDevelopment
approved these changes
Feb 18, 2025
f079ee2 to
079388d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Java's
Runtime.availableProcessors()return number of available processors in the system, but starting Spark session withmaster=local[N]applies the hard limit for the number of executor threads. So even if system has a lot of processor cores available, only some of them will be used by Spark.This lead to showing a warning that the number of Greenplum connections is high even if Spark session was started with
master=local[1]ormaster=local[10](max 10 executors, so max 10 connections to GP, warning threshold is 30).Fixed, added a bunch of unit tests, using mocks to cover different cases (master=local, master=yarn with static allocation, master=yarn with dynamic allocation).
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)