Skip to content

[DOP-23979] Change default FileDFWriter.Options(if_exists) to APPEND#343

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-23979
Feb 18, 2025
Merged

[DOP-23979] Change default FileDFWriter.Options(if_exists) to APPEND#343
dolfinus merged 1 commit intodevelopfrom
feature/DOP-23979

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 18, 2025

Change Summary

Make default value of FileDFWriter.Options(if_exists=...) consistent with DB connections, which use APPEND.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 18, 2025
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.97%. Comparing base (60aea9e) to head (f71a402).
Report is 67 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    92.02%   91.97%   -0.06%     
===========================================
  Files          228      228              
  Lines         9867     9867              
  Branches      1013     1013              
===========================================
- Hits          9080     9075       -5     
- Misses         599      602       +3     
- Partials       188      190       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review February 18, 2025 14:52
@dolfinus dolfinus merged commit 562a3dc into develop Feb 18, 2025
42 checks passed
@dolfinus dolfinus deleted the feature/DOP-23979 branch February 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants