Skip to content

Return full path in list_dir/walk#381

Merged
dolfinus merged 1 commit intodevelopfrom
feature/file-connection-return-path
Aug 25, 2025
Merged

Return full path in list_dir/walk#381
dolfinus merged 1 commit intodevelopfrom
feature/file-connection-return-path

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 22, 2025

Change Summary

Other methods, like upload_file, move_file and so on, return RemoteFile/RemoteDirectory with real path. But list_dir and walk return RemoteFile/RemoteDirectory containing only name, with no path. This requires using strange workarounds in FileDownloader/Mover code.

Fixed to keep all FileConnection methods consistent.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Aug 22, 2025
@dolfinus dolfinus force-pushed the feature/file-connection-return-path branch from 45ab156 to d7607a9 Compare August 22, 2025 12:18
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.70%. Comparing base (929e13c) to head (8452c78).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...netl/connection/file_connection/file_connection.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage    93.75%   93.70%   -0.05%     
===========================================
  Files          231      231              
  Lines        10212    10222      +10     
  Branches       984      985       +1     
===========================================
+ Hits          9574     9579       +5     
- Misses         489      491       +2     
- Partials       149      152       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus force-pushed the feature/file-connection-return-path branch from d7607a9 to abfad13 Compare August 22, 2025 12:41
@dolfinus dolfinus force-pushed the feature/file-connection-return-path branch from abfad13 to 191b495 Compare August 22, 2025 17:13
@dolfinus dolfinus changed the title Add file/dir path to list_dir/walk results Return full path in list_dir/walk Aug 22, 2025
@dolfinus dolfinus force-pushed the feature/file-connection-return-path branch from 191b495 to 99a38e2 Compare August 22, 2025 17:14
@dolfinus dolfinus force-pushed the feature/file-connection-return-path branch from 99a38e2 to 8452c78 Compare August 25, 2025 08:04
@dolfinus dolfinus marked this pull request as ready for review August 25, 2025 08:28
@dolfinus dolfinus merged commit abbfde8 into develop Aug 25, 2025
39 checks passed
@dolfinus dolfinus deleted the feature/file-connection-return-path branch August 25, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants