[DOP-5632] Split FileLimit to separate limits#44
Merged
Conversation
3f571b3 to
0e15d0f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #44 +/- ##
===========================================
+ Coverage 92.94% 93.04% +0.09%
===========================================
Files 120 124 +4
Lines 5770 5822 +52
Branches 1001 1006 +5
===========================================
+ Hits 5363 5417 +54
+ Misses 313 312 -1
+ Partials 94 93 -1
|
andy-takker
reviewed
May 25, 2023
andy-takker
reviewed
May 25, 2023
7dfa680 to
ca5439c
Compare
andy-takker
reviewed
May 25, 2023
ca5439c to
f104a5f
Compare
andy-takker
approved these changes
May 26, 2023
dmitry-pedchenko
approved these changes
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onetl.file.limitmoduleFileLimit(count_limit=10)class withMaxFilesCount(10), placed new class to new module, added documentation & unit tests.limits_reachedto new module, renamed tolimits_stop_at, to show that it checks a specific path against limits, added unit tests & documentation.limits_reachedandreset_limitswhich previously were a part ofFileConnection.list_dirand.walk. They can help other developers to implement new modules in the future. Documented and tested them as well.BaseFileLimitBaseFileLimit.reset()method - now the return value is used as a new limit, so it now depends on developer, should it resett a limit object state in-place or create a copy.Documentation: https://onetl--44.org.readthedocs.build/en/44/file_limit/index.html