[DOP-2329] Generate config for authorization in Kafka#63
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
- Coverage 93.14% 93.14% -0.01%
===========================================
Files 126 126
Lines 6101 6130 +29
Branches 1144 1149 +5
===========================================
+ Hits 5683 5710 +27
- Misses 321 322 +1
- Partials 97 98 +1
|
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
tests/tests_integration/tests_db_connection_integration/test_kafka_integration.py
Outdated
Show resolved
Hide resolved
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
dolfinus
reviewed
Jul 6, 2023
tests/tests_integration/tests_db_connection_integration/test_kafka_integration.py
Outdated
Show resolved
Hide resolved
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dolfinus
reviewed
Jul 7, 2023
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dolfinus
reviewed
Jul 7, 2023
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
Member
|
Проверь логи flake8, он на что-то ругается |
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
dolfinus
approved these changes
Jul 10, 2023
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
andy-takker
approved these changes
Jul 10, 2023
dmitry-pedchenko
force-pushed
the
feature/DOP-2329
branch
from
5777fcb to
d5ac602
Compare
dmitry-pedchenko
temporarily deployed
to
test-pypi
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The class must have a private method for generating a JAAS config that Kafka uses for authorization.
Related issue number
DOP-2329
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)