[DOP-7529] - create class Kafka.Dialect and its tests#72
Merged
maxim-lixakov merged 6 commits intodevelopfrom Jul 18, 2023
Merged
[DOP-7529] - create class Kafka.Dialect and its tests#72maxim-lixakov merged 6 commits intodevelopfrom
maxim-lixakov merged 6 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #72 +/- ##
===========================================
+ Coverage 92.61% 92.64% +0.02%
===========================================
Files 134 136 +2
Lines 6095 6115 +20
Branches 1125 1127 +2
===========================================
+ Hits 5645 5665 +20
Misses 348 348
Partials 102 102
|
dolfinus
reviewed
Jul 17, 2023
dolfinus
reviewed
Jul 17, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
dolfinus
reviewed
Jul 17, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
5a84921 to
526fded
Compare
dolfinus
reviewed
Jul 17, 2023
dolfinus
reviewed
Jul 17, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
dolfinus
reviewed
Jul 17, 2023
tests/tests_unit/test_db/test_db_reader_unit/test_kafka_reader_unit.py
Outdated
Show resolved
Hide resolved
dolfinus
approved these changes
Jul 17, 2023
dmitry-pedchenko
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
class KafkaDialectto validate parameters of querying data from sourceclass SupportWhereNoneto use with connections' dialectsRelated issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)