Skip to content

[DOP-7529] - create class Kafka.Dialect and its tests#72

Merged
maxim-lixakov merged 6 commits intodevelopfrom
feature/DOP-7529
Jul 18, 2023
Merged

[DOP-7529] - create class Kafka.Dialect and its tests#72
maxim-lixakov merged 6 commits intodevelopfrom
feature/DOP-7529

Conversation

@maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Jul 17, 2023

Change Summary

  • add class KafkaDialect to validate parameters of querying data from source
  • add tests for KafkaDialect
  • add mixin class SupportWhereNone to use with connections' dialects

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #72 (bae957d) into develop (abfa7b4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
+ Coverage    92.61%   92.64%   +0.02%     
===========================================
  Files          134      136       +2     
  Lines         6095     6115      +20     
  Branches      1125     1127       +2     
===========================================
+ Hits          5645     5665      +20     
  Misses         348      348              
  Partials       102      102              
Impacted Files Coverage Δ
...onnection/db_connection/dialect_mixins/__init__.py 100.00% <100.00%> (ø)
...db_connection/dialect_mixins/support_where_none.py 100.00% <100.00%> (ø)
onetl/connection/db_connection/kafka/connection.py 91.66% <100.00%> (+0.17%) ⬆️
onetl/connection/db_connection/kafka/dialect.py 100.00% <100.00%> (ø)

@dolfinus dolfinus temporarily deployed to test-pypi July 17, 2023 10:32 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov marked this pull request as ready for review July 17, 2023 10:41
@maxim-lixakov maxim-lixakov self-assigned this Jul 17, 2023
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 17, 2023 10:57 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 17, 2023 11:36 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi July 18, 2023 09:07 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov merged commit 07ff159 into develop Jul 18, 2023
@maxim-lixakov maxim-lixakov deleted the feature/DOP-7529 branch July 18, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants