Skip to content

[DOP-20893] Add <role> attribute to /v1/groups/:id response#109

Merged
IlyasDevelopment merged 2 commits intodevelopfrom
feature/DOP-20893
Oct 21, 2024
Merged

[DOP-20893] Add <role> attribute to /v1/groups/:id response#109
IlyasDevelopment merged 2 commits intodevelopfrom
feature/DOP-20893

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Oct 21, 2024

Change Summary

GET /v1/groups/:id endpoint changed the response format from:

{
  “id": 123,
  “name": "abc",
  “description": “cde”
}

to

{
  “data": {
    “id": 123,
    “name": "abc",
    “description": “cde”
  }, 
  “role”: “DEVELOPER”
}

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment self-assigned this Oct 21, 2024
@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (b0d4560) to head (59f8d53).
Report is 80 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
+ Coverage    92.79%   92.81%   +0.02%     
===========================================
  Files           98       98              
  Lines         2803     2811       +8     
  Branches       228      229       +1     
===========================================
+ Hits          2601     2609       +8     
  Misses         150      150              
  Partials        52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment merged commit 51cb297 into develop Oct 21, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-20893 branch October 21, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants