Skip to content

[BREAKING] - remove is_deleted for Connection model#170

Merged
maxim-lixakov merged 2 commits intodevelopfrom
breaking/remove_connection_is_deleted
Dec 16, 2024
Merged

[BREAKING] - remove is_deleted for Connection model#170
maxim-lixakov merged 2 commits intodevelopfrom
breaking/remove_connection_is_deleted

Conversation

@maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Dec 13, 2024

Change Summary

  • Add deletion of connections records instead of marking them as deleted
  • Update following tests

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Dec 13, 2024
@maxim-lixakov maxim-lixakov self-assigned this Dec 13, 2024
@maxim-lixakov maxim-lixakov force-pushed the breaking/remove_connection_is_deleted branch from b9cfba3 to e1079a2 Compare December 16, 2024 09:25
@maxim-lixakov maxim-lixakov force-pushed the breaking/remove_connection_is_deleted branch from e1079a2 to 9efe035 Compare December 16, 2024 09:26
@maxim-lixakov maxim-lixakov marked this pull request as ready for review December 16, 2024 09:27
@maxim-lixakov maxim-lixakov merged commit 3a325f9 into develop Dec 16, 2024
@maxim-lixakov maxim-lixakov deleted the breaking/remove_connection_is_deleted branch December 16, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants