Skip to content

[DOP-22337] Add logic for handling Samba transfers#192

Merged
IlyasDevelopment merged 1 commit intodevelopfrom
feature/DOP-22337
Jan 31, 2025
Merged

[DOP-22337] Add logic for handling Samba transfers#192
IlyasDevelopment merged 1 commit intodevelopfrom
feature/DOP-22337

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Jan 31, 2025

Change Summary

  • Added necessary DTOs for Samba integration
  • Implemented Samba handler:
    • For reading, used a combination of FileDownloader and FileDFReader
    • For writing, used FileDFWriter and FileUploader
  • Added a container with Samba server for testing purposes
  • Developed integration tests for reading and writing files via Samba
  • Updated CI pipeline to include the execution of integration tests

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment merged commit a217fa5 into develop Jan 31, 2025
23 checks passed
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-22337 branch January 31, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants