Skip to content

[DOP-28389] Improve group member role check#375

Closed
dolfinus wants to merge 1 commit into
developfrom
bugfix/DOP-28389
Closed

[DOP-28389] Improve group member role check#375
dolfinus wants to merge 1 commit into
developfrom
bugfix/DOP-28389

Conversation

@dolfinus
Copy link
Copy Markdown
Member

@dolfinus dolfinus commented May 26, 2026

Change Summary

If user has superuser permission, GET /v1/groups returns role: SUPERUSER, but GET /v1/groups/:id doesn't. Applied a fix, and also simplified permission check a bit.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this May 26, 2026
@github-actions
Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
syncmaster/db/repositories
   group.py1431036593%162–163, 199, 238–239, 366–369, 377
   queue.py83524193%70–71, 79–80, 179
TOTAL535463782817188% 

@dolfinus dolfinus closed this May 26, 2026
@dolfinus dolfinus deleted the bugfix/DOP-28389 branch May 26, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant