Clean up safe Ruff findings in Stromligning sensor modules#283
Merged
Conversation
MTrab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the safe Ruff findings in the Stromligning sensor and binary sensor modules.
It removes unused imports, avoids import shadowing in setup loops, updates docstrings to satisfy Ruff, and refactors
sensor.pysohandle_attributesuses explicit attribute maps forATTR_PRICESandatvalues.The state path is intentionally left unchanged: the
value_fndefinitions,handle_update()assignment to_attr_native_value, and the API methods used for sensor state are untouched.Test strategy
Ran
ruff check custom_components/stromligning/binary_sensor.py custom_components/stromligning/sensor.py.Known limitations
This PR does not add new tests.
Configuration changes
None.
Proposed semver label
patch(not set in GitHub yet; awaiting maintainer verification before any label change)