Skip to content

switch qtkeychain repository to mainline#529

Merged
nschimme merged 1 commit into
masterfrom
nschimme-patch-1
May 4, 2026
Merged

switch qtkeychain repository to mainline#529
nschimme merged 1 commit into
masterfrom
nschimme-patch-1

Conversation

@nschimme
Copy link
Copy Markdown
Contributor

@nschimme nschimme commented May 4, 2026

Wasm support was merged into mainline

Summary by Sourcery

Build:

  • Update qtkeychain ExternalProject configuration to point to the mainline repository at a fixed revision instead of a forked wasm branch.

Wasm support was merged into mainline
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 4, 2026

🧙 Sourcery is reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief comment in the CMake file explaining why qtkeychain is pinned to this specific commit hash so future maintainers understand the rationale for not tracking a tag or release.
  • If qtkeychain publishes stable tags (e.g., release tags), consider pinning to a tag instead of a raw commit hash to make future updates and audits of third-party dependencies easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief comment in the CMake file explaining why qtkeychain is pinned to this specific commit hash so future maintainers understand the rationale for not tracking a tag or release.
- If qtkeychain publishes stable tags (e.g., release tags), consider pinning to a tag instead of a raw commit hash to make future updates and audits of third-party dependencies easier.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nschimme nschimme merged commit f7c41f0 into master May 4, 2026
18 checks passed
@nschimme nschimme deleted the nschimme-patch-1 branch May 4, 2026 16:26
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.36%. Comparing base (df720b1) to head (ef4b024).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   25.36%   25.36%           
=======================================
  Files         519      519           
  Lines       43181    43181           
  Branches     4704     4705    +1     
=======================================
  Hits        10952    10952           
  Misses      32229    32229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant