switch qtkeychain repository to mainline#529
Merged
Merged
Conversation
Wasm support was merged into mainline
|
🧙 Sourcery is reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief comment in the CMake file explaining why qtkeychain is pinned to this specific commit hash so future maintainers understand the rationale for not tracking a tag or release.
- If qtkeychain publishes stable tags (e.g., release tags), consider pinning to a tag instead of a raw commit hash to make future updates and audits of third-party dependencies easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief comment in the CMake file explaining why qtkeychain is pinned to this specific commit hash so future maintainers understand the rationale for not tracking a tag or release.
- If qtkeychain publishes stable tags (e.g., release tags), consider pinning to a tag instead of a raw commit hash to make future updates and audits of third-party dependencies easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 25.36% 25.36%
=======================================
Files 519 519
Lines 43181 43181
Branches 4704 4705 +1
=======================================
Hits 10952 10952
Misses 32229 32229 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasm support was merged into mainline
Summary by Sourcery
Build: