Fix Weapon Skill Links and Update Skills Hub Structure#20
Merged
Fix Weapon Skill Links and Update Skills Hub Structure#20
Conversation
- Updated `includes/Skills.md` to list all individual weapon skills instead of a condensed link. - Corrected categorization: 'Piercing weapons' and 'Missile weapons' are now exclusively Thief skills. - Added 'Unarmed combat' (Warrior/Troll) and 'Dark oath' (Ranger/Black Númenórean). - Updated `pages/Skill.md` to match the new skill structure. - Fixed incorrect links in `pages/Thief.md`. - Cross-pollinated weapon skill pages with weapon item lists. - Cleaned up redundant "See also" sections in weapon skill pages.
- Capitalized 'Trolls' in `Unarmed.md` for consistency.
- Expanded `includes/Skills.md` and `Skill.md` to show individual weapon skills. - Corrected skill categorization: Missile and Piercing weapons are now Thief-only. - Added 'Unarmed combat' (Warrior/Troll) and 'Dark oath' (Ranger/BN). - Cross-pollinated weapon skill pages with corresponding item list pages. - Linked weapon skill pages to relevant guides (Troll guide, Warrior guide, Missile guide). - Cleaned up redundant 'See also' sections in weapon skill pages. - Fixed incorrect item hub links to point directly to skill pages.
Contributor
Reviewer's GuideRefactors the skills hub and weapon skill documentation to correct skill ownership, fix and standardize links/names, and add a new Dark Oath ranger skill page with better cross-linking between guides and weapon/skill pages. Class diagram for updated skills hub and weapon skill documentation structureclassDiagram
class Skill {
}
class Warrior {
}
class Ranger {
}
class Thief {
}
class Skills_include {
}
class Cleaving_weapons {
}
class Concussion_weapons {
}
class Slashing_weapons {
}
class Stabbing_weapons {
}
class Two_handed_weapons {
}
class Unarmed_combat {
}
class Charging_weapons {
}
class Missile_weapons {
}
class Piercing_weapons {
}
class Dark_oath {
}
class Cleaving_weapon {
}
class Concussion_weapon {
}
class Slashing_weapon {
}
class Stabbing_weapon {
}
class Two_handed_weapon {
}
class Piercing_weapon {
}
class Ranged_weapon {
}
class Newbie_Guide_to_Warrior_Skills {
}
class Newbie_Guide_to_Missile_Weapons {
}
class Troll_guide {
}
class Thief_guide {
}
class Black_NumenoRean {
}
class Sauron {
}
class Call_skill {
}
class Fell_Beast {
}
%% Skills hub relationships
Skill --> Warrior : lists_skills_for
Skill --> Ranger : lists_skills_for
Skill --> Thief : lists_skills_for
Skill --> Skills_include : includes
%% Warrior weapon skills
Warrior --> Cleaving_weapons : warrior_skill
Warrior --> Concussion_weapons : warrior_skill
Warrior --> Slashing_weapons : warrior_skill
Warrior --> Stabbing_weapons : warrior_skill
Warrior --> Two_handed_weapons : warrior_skill
Warrior --> Unarmed_combat : warrior_skill
Warrior --> Charging_weapons : warrior_skill
%% Thief weapon skills
Thief --> Missile_weapons : thief_skill
Thief --> Piercing_weapons : thief_skill
%% Ranger special skill
Ranger --> Dark_oath : ranger_skill
Dark_oath --> Black_NumenoRean : race_limited
Dark_oath --> Sauron : devotion_to
Dark_oath --> Call_skill : enables
Call_skill --> Fell_Beast : summons
%% Weapon skills to weapon lists
Cleaving_weapons --> Cleaving_weapon : lists_weapons
Concussion_weapons --> Concussion_weapon : lists_weapons
Slashing_weapons --> Slashing_weapon : lists_weapons
Stabbing_weapons --> Stabbing_weapon : lists_weapons
Two_handed_weapons --> Two_handed_weapon : lists_weapons
Piercing_weapons --> Piercing_weapon : lists_weapons
Missile_weapons --> Ranged_weapon : lists_weapons
%% Weapon skills to guides
Cleaving_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Concussion_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Slashing_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Stabbing_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Two_handed_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Charging_weapons --> Newbie_Guide_to_Warrior_Skills : linked_guide
Missile_weapons --> Newbie_Guide_to_Missile_Weapons : linked_guide
Unarmed_combat --> Troll_guide : linked_guide
Piercing_weapons --> Thief_guide : linked_guide
%% Shared skills navigation include
Cleaving_weapons --> Skills_include : uses_nav_include
Concussion_weapons --> Skills_include : uses_nav_include
Slashing_weapons --> Skills_include : uses_nav_include
Stabbing_weapons --> Skills_include : uses_nav_include
Two_handed_weapons --> Skills_include : uses_nav_include
Unarmed_combat --> Skills_include : uses_nav_include
Charging_weapons --> Skills_include : uses_nav_include
Missile_weapons --> Skills_include : uses_nav_include
Piercing_weapons --> Skills_include : uses_nav_include
Dark_oath --> Skills_include : uses_nav_include
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
- Standardized "Dark oath" capitalization across all files. - Appended " weapons" to Warrior weapon skill labels in `includes/Skills.md` for clarity.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- There’s inconsistent capitalization/wording for Dark oath/Dark Oath across
Skill.md("Dark oath"),Skills.md("Dark Oath") andDark_oath.md(page title "Dark oath"), which could be normalized so link text and page titles match consistently. - After inlining the individual weapon skills into
includes/Skills.md, consider whether the older aggregatedWeapon.mdpage is still needed; if it’s effectively superseded, you might want to either deprecate it explicitly or update any remaining references to avoid confusing duplicate entry points.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s inconsistent capitalization/wording for Dark oath/Dark Oath across `Skill.md` ("Dark oath"), `Skills.md` ("Dark Oath") and `Dark_oath.md` (page title "Dark oath"), which could be normalized so link text and page titles match consistently.
- After inlining the individual weapon skills into `includes/Skills.md`, consider whether the older aggregated `Weapon.md` page is still needed; if it’s effectively superseded, you might want to either deprecate it explicitly or update any remaining references to avoid confusing duplicate entry points.
## Individual Comments
### Comment 1
<location path="docs/pages/Skill.md" line_range="35-37" />
<code_context>
+Special
+
+- [Dark oath (Black Númenórean)](./Dark_oath.md)
+
## [Thief](./Thief.md)
</code_context>
<issue_to_address>
**suggestion (typo):** Consider making the "Dark oath / Dark Oath" capitalization consistent with the skill page and other references.
This entry uses "Dark oath", while `Dark_oath.md` mixes "Dark oath" (title) and "Dark Oath" (body), and `Skills.md` uses "Dark Oath". Please align the capitalization across these references for consistency.
```suggestion
Special
- [Dark Oath (Black Númenórean)](./Dark_oath.md)
```
</issue_to_address>
### Comment 2
<location path="docs/pages/Dark_oath.md" line_range="2-10" />
<code_context>
+---
+title: Dark oath
+description: 'This is a Black Númenórean-only Ranger skill.'
+tags:
+ - Ranger skills
+ - Skills
+---
+This is a [Black Númenórean](./Black_Númenórean.md)-only [Ranger](./Ranger.md) [skill](./Skill.md).
+
+Through the use of a **Dark Oath**, a servant of the [Dark Lord](./Sauron.md) may pledge themselves to his will and gain evil knowledge. Those that wrap themselves in the [Dark Lord's](./Sauron.md) power can move undetected among their foes over extended distances, [call](./Call.md) [fell beasts](./Fell_Beast.md), and possess enhanced [endurance](./Endurance.md), albeit at the expense of reduced concentration.
+
+Example:
</code_context>
<issue_to_address>
**suggestion (typo):** The skill name appears as both "Dark oath" and "Dark Oath"; consider standardizing it here and across references.
Here the title uses "Dark oath" while the body and `Skills.md` use "Dark Oath". Please pick one canonical capitalization for the skill name and use it consistently in this page (title/body) and any related navigation or index entries.
Suggested implementation:
```
title: Dark Oath
```
To fully standardize this across the project, you may also want to:
1. Rename the file from `Dark_oath.md` to `Dark_Oath.md` (or another consistent naming convention) and update any incoming links to this page.
2. Check any navigation/index files (e.g., sidebars, skill lists) to ensure they all refer to the skill as "Dark Oath".
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+35
to
+37
| Special | ||
|
|
||
| - [Dark oath (Black Númenórean)](./Dark_oath.md) |
Contributor
There was a problem hiding this comment.
suggestion (typo): Consider making the "Dark oath / Dark Oath" capitalization consistent with the skill page and other references.
This entry uses "Dark oath", while Dark_oath.md mixes "Dark oath" (title) and "Dark Oath" (body), and Skills.md uses "Dark Oath". Please align the capitalization across these references for consistency.
Suggested change
| Special | |
| - [Dark oath (Black Númenórean)](./Dark_oath.md) | |
| Special | |
| - [Dark Oath (Black Númenórean)](./Dark_oath.md) |
Comment on lines
+2
to
+10
| title: Dark oath | ||
| description: 'This is a Black Númenórean-only Ranger skill.' | ||
| tags: | ||
| - Ranger skills | ||
| - Skills | ||
| --- | ||
| This is a [Black Númenórean](./Black_Númenórean.md)-only [Ranger](./Ranger.md) [skill](./Skill.md). | ||
|
|
||
| Through the use of a **Dark Oath**, a servant of the [Dark Lord](./Sauron.md) may pledge themselves to his will and gain evil knowledge. Those that wrap themselves in the [Dark Lord's](./Sauron.md) power can move undetected among their foes over extended distances, [call](./Call.md) [fell beasts](./Fell_Beast.md), and possess enhanced [endurance](./Endurance.md), albeit at the expense of reduced concentration. |
Contributor
There was a problem hiding this comment.
suggestion (typo): The skill name appears as both "Dark oath" and "Dark Oath"; consider standardizing it here and across references.
Here the title uses "Dark oath" while the body and Skills.md use "Dark Oath". Please pick one canonical capitalization for the skill name and use it consistently in this page (title/body) and any related navigation or index entries.
Suggested implementation:
title: Dark Oath
To fully standardize this across the project, you may also want to:
- Rename the file from
Dark_oath.mdtoDark_Oath.md(or another consistent naming convention) and update any incoming links to this page. - Check any navigation/index files (e.g., sidebars, skill lists) to ensure they all refer to the skill as "Dark Oath".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
::: details Spoiler) as defined in the Contributing Guide.docker compose up --build wiki(ornpm run docs:build) and verified changes locally.docs/guides.md,docs/classes.md) if a major new page was added.Summary by Sourcery
Improve the skills documentation structure and correct weapon-related skill links across the wiki.
New Features:
Enhancements:
Documentation: