Skip to content

feat: add max magic speed #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sven-n merged 2 commits into from
Nov 21, 2025
Merged

feat: add max magic speed #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730ac40
feat: add max magic speed
5Miro Nov 16, 2025
9cd0159
Change the values back to default
5Miro Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/GameLogic/Attributes/Stats.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,10 @@ public class Stats
/// <summary>
/// Gets the magic speed attribute definition which is used for some skills.
/// </summary>
public static AttributeDefinition MagicSpeed { get; } = new(new Guid("AE32AA45-9C18-43B3-9F7B-648FD7F4B0AD"), "Magic Speed", string.Empty);
public static AttributeDefinition MagicSpeed { get; } = new(new Guid("AE32AA45-9C18-43B3-9F7B-648FD7F4B0AD"), "Magic Speed", string.Empty)
{
MaximumValue = 200,
};

/// <summary>
/// Gets the wizardry base (min and max) damage increase attribute definition>.
Expand Down
1 change: 1 addition & 0 deletions src/Persistence/Initialization/Updates/FixAttackSpeedCalculationUpdate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ protected override async ValueTask ApplyAsync(IContext context, GameConfiguratio
AddStatIfNotExists(context, gameConfiguration, Stats.WalkSpeed);

Stats.AttackSpeed.GetPersistent(gameConfiguration).MaximumValue = Stats.AttackSpeed.MaximumValue;
Stats.MagicSpeed.GetPersistent(gameConfiguration).MaximumValue = Stats.MagicSpeed.MaximumValue;
Copy link
Copy Markdown
Member

@sven-n sven-n Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work when someone has already run this update.
To make this work 100% correct, you'd need to add a new separate update plugin.
However, for such a small change, we can also ignore it.


foreach (var characterClass in gameConfiguration.CharacterClasses)
{
Expand Down