SWA auth #24
Merged
SWA auth #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Static Web App authentication configuration to protect API endpoints and handle unauthenticated access. However, the implementation contains several critical issues that will prevent the configuration from working correctly.
- Addition of
staticwebapp.config.jsonto configure authentication and routing rules for Azure Static Web Apps - Update to the project file to copy the configuration file during build
- Configuration of routes to restrict API access and handle 401 responses
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Bezalu.ProjectReporting.Web/staticwebapp.config.json | Adds Static Web App configuration with authentication rules, but contains critical JSON syntax errors and authentication provider inconsistencies |
| Bezalu.ProjectReporting.Web/Bezalu.ProjectReporting.Web.csproj | Configures build to copy staticwebapp.config.json, but references incorrect file path (wwwroot instead of project root) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@MWG-Logan I've opened a new pull request, #25, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces configuration for static web app authentication and routing in the project. The main changes are the addition of a
staticwebapp.config.jsonfile to define custom routes, authentication rules, and response overrides, and ensuring this configuration is copied to the output directory during builds.Static web app configuration:
staticwebapp.config.jsontowwwrootwith routes restricting/api/*to authenticated users, a custom login route, and a 401 response override to redirect unauthenticated users to GitHub login.Build process update:
Bezalu.ProjectReporting.Web.csprojto copystaticwebapp.config.jsonto the output directory on build, ensuring deployment includes the correct configuration.