RFC0017 switching between FOL and manual mode#15
Merged
Ahelsamahy merged 4 commits intoRFC0008_Followingfrom Feb 28, 2024
Merged
RFC0017 switching between FOL and manual mode#15Ahelsamahy merged 4 commits intoRFC0008_Followingfrom
Ahelsamahy merged 4 commits intoRFC0008_Followingfrom
Conversation
As the old function could be only called on the button call and couldn't be exported. I had to wrap it in a function I can export, but the function was doing more than one process (changing the text on button and sending POST with the command) so I split it into class.
…or the button There was implementation done for hiding the button on immediate break (part of the smooth breaking RFC16) and now it needs another way to access it through the class
In hiding and showing the button while the user is interacting with the active area
It will read the current state of button before it starts drawing the triangles where the OP fingers are placed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Following (FOL) mode keeps working even if the user is touching the active area on the mobile controller. This raises the problem if the user wants to change the immediate action of the robot in case of an accident. This feature will allow the user to switch from Following mode to normal mode as fast as possible.
What is changed: