Skip to content

#91 Fix: 회원정보 수정 응답DTO수정 #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jaehooni merged 1 commit into from
Feb 20, 2024
Merged

#91 Fix: 회원정보 수정 응답DTO수정 #92

Jaehooni merged 1 commit into from
Feb 20, 2024

Conversation

@junstory
Copy link
Contributor

@junstory junstory commented Feb 20, 2024 •
edited
Loading

Fix: 회원정보 수정 응답DTO수정

구현 내용

  • 회원정보 수정 기능에서 중복된 닉네임이 있을 시 오류 -> 기존 정보 return

To Reviewrs

image

  • 기존 오류 메세지와 중복되는 닉네임을 리턴하는 방식에서 사진과 같이 메세지는 오류임을 알려주되 기존 데이터를 보내도록 수정하였습니다.
  • response.status에서 SUCCESS부분의 code가 다른 응답이 String인 경우와 달리 2000(number)이라 String으로 바꿔주었습니다!

Check List

  • 계획한 구현이 빠짐없이 구현됐는가?
  • 오류없이 제대로 동작하는가?

@junstory junstory added the FIX 🚑 버그 수정 label Feb 20, 2024
@junstory junstory self-assigned this Feb 20, 2024
@Jaehooni
Copy link
Contributor

Jaehooni commented Feb 20, 2024

LGTM!

@junstory junstory linked an issue Feb 20, 2024 that may be closed by this pull request
Fix: 회원정보 수정 response 변경 #91
Open
1 task
@Jaehooni Jaehooni merged commit deb4da1 into develop Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jaehooni Jaehooni Awaiting requested review from Jaehooni

@alreadynyeong alreadynyeong Awaiting requested review from alreadynyeong

Assignees

@junstory junstory

Labels

FIX 🚑 버그 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix: 회원정보 수정 response 변경

3 participants

@junstory @Jaehooni