-
Notifications
You must be signed in to change notification settings - Fork 0
Set envvar OMP_NUM_THREDS=1 in spindynamics notebooks #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5c25327 to
392f312
Compare
fangohr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Three items of feedback:
- It appears the actual change to the notebook is missing:
-
The change in the metadata (change of python version used) should not be in the commit change, I think.
-
For this tiny change I would suggest we merge (once resolved), and force push the tag 0.11.0 again to get an update of the webpages. We may have more small changes on the wording of the notebooks, which also do not warrant a new version I think. If we do this, we don't need add
58.fixed.miI think. (Do you agree?)
|
I run the whole notebook and pushed the changes.
For me this would be the best to-do-list:
If you don't agree, we can push this PR directly as well (but people running the notebook might see the list in the |
392f312 to
d74dc56
Compare
d74dc56 to
560c8b6
Compare
560c8b6 to
755f1f5
Compare
Please never force-push a version tag to rebuild the webpages. Instead, manually trigger the documentation action on main: https://github.com/MaMMoS-project/mammos/actions/workflows/documentation.yml and tick the box to deploy changes:
To get updated notebooks for binder only force-push the |


Closes MaMMoS-project/management#362