asynchroneaus forecast fetcher via schedule()#223
Merged
Conversation
This commit introduces internal scheduling to enable async. data refresh. Data refresh can happens in the main loop during fetch_forecast or in the scheduled task. Which comes first, it is holding a lock during refresh. If a lock is already there, we are skipping the refresh_data part, because the relaxed_caching class should create a possible concurrency.
MaStr
changed the title
Owner
Author
|
This PR is running on my production environment for verification. By now, I can tell, that a few requests are still processed in the main loop. The scheduling does work, but it happens that the refresh interval of the main-loop does fit better with the scheduled one. In the scheduler, the same refresh_data is called and each provider needs to verify if it does a refresh or not. Not sure, if that behavior is sufficient or not. cc @johannesghd for a qualified comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77