tests: address post-merge review feedback#322
Merged
MaStr merged 1 commit intoMaStr:mainfrom Apr 14, 2026
Merged
Conversation
Owner
|
Hi, thanks for following up on these points. I was not sure, if you are pro or contra the copilot review, that was the reason I took the comments as a 2nd opinion and not mandatory. In the future, I'll keep the copilot review as a additional opinion. In the past, it made good review points on my changes, too. |
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up test-only changes to incorporate post-merge review feedback, improving isolation and robustness of the existing test suite.
Changes:
- Refactors
test_production_offsetsetup to constructBatcontrolinstances via a factory fixture and ensure shutdown happens for all created instances. - Adds an autouse fixture in inverter factory tests to reset
Inverter.num_invertersper test for deterministic behavior. - Loosens the unknown-inverter-type assertion to avoid coupling to the current production error-message typo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/batcontrol/test_production_offset.py |
Introduces a make_batcontrol fixture to ensure instances are created within patched factory context and reliably shut down. |
tests/batcontrol/inverter/test_inverter_factory.py |
Resets global inverter instance counter per test and relaxes the error-message regex match for unknown types. |
MaStr
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on a couple of useful Copilot review points from already-merged test PRs.
It addresses the factory-test feedback from #320 by resetting
Inverter.num_invertersper test and by loosening the unknown-type assertion so it no longer bakes in the current typo in the production error message:It also addresses the #321 feedback on
test_production_offset_initialization_default, which was still constructing a freshBatcontrol(...)outside the patched fixture setup: