tests: characterize inverter baseclass battery math#333
Merged
MaStr merged 1 commit intoMaStr:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds targeted characterization tests for the shared battery capacity/energy math implemented in InverterBaseclass, ensuring the current SOC-based calculations remain stable across refactors.
Changes:
- Introduces a
FakeInvertertest double to exerciseInverterBaseclassmath in isolation. - Adds unit tests covering stored energy, stored usable energy, max capacity, usable capacity, and free capacity behavior above
max_soc.
MaStr
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds characterization tests for the shared battery-capacity math in
InverterBaseclass, covering stored energy, usable energy, max capacity, usable capacity, and current free-capacity behavior abovemax_soc.