mqtt: polish published state values#353
Merged
MaStr merged 1 commit intoMaStr:mainfrom Apr 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes MQTT state publishing to better align with Home Assistant expectations and reconnect behavior in batcontrol’s MQTT integration.
Changes:
- Publish SOC with decimal precision (2 decimals) instead of zero-padded integers.
- Normalize
discharge_blockedpublished payloads to lowercase (true/false) and fix its HA discoveryvalue_template. - Fix reconnect subscription logic to avoid duplicate subscriptions, and add regression tests for these behaviors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/batcontrol/mqtt_api.py |
Fixes reconnect subscribe loop, improves SOC formatting, normalizes discharge_blocked payloads, and corrects HA discovery template logic. |
tests/batcontrol/test_mqtt_api.py |
Adds tests covering reconnect subscription behavior and published state payload formatting / discovery template expectations. |
d6e4f8b to
8bc1b1f
Compare
MaStr
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes SoC with decimal precision, normalizes discharge-blocked state to lowercase booleans, fixes its HA discovery template, and avoids duplicate MQTT subscriptions on reconnect.