Error launching CC after new update

[bel57]

Hello

Updated to latest version of ColorControl and I get the following error, can you please help/fix it?
It looks like you left some direct path dependent of your username/local files (C:\Users\vinni\source\repos\ColorControl)

---------------------------
Error
---------------------------
Error while initializing application: C:\WINDOWS\system32\ColorControl.exe

   at System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName)

   at ColorControl.MainForm.InitInfo() in C:\Users\vinni\source\repos\ColorControl\ColorControl\MainForm.cs:line 358

   at ColorControl.MainForm..ctor(AppContextProvider appContextProvider, PowerEventDispatcher powerEventDispatcher, ServiceManager serviceManager) in C:\Users\vinni\source\repos\ColorControl\ColorControl\MainForm.cs:line 135

   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)

   at System.Reflection.ConstructorInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)

   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)

   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite callSite, RuntimeResolverContext context)

   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)

   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)

   at Microsoft.Extensions.DependencyInjection.ServiceProvider.CreateServiceAccessor(Type serviceType)

   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)

   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)

   at Microsoft.Extensions.DependencyInjection.ServiceProvider.GetService(Type serviceType)

   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)

   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)

   at ColorControl.Program.MainAsync(String[] args) in C:\Users\vinni\source\repos\ColorControl\ColorControl\Program.cs:line 142

   at ColorControl.Program.Main(String[] args) in C:\Users\vinni\source\repos\ColorControl\ColorControl\Program.cs:line 46
---------------------------
OK   
---------------------------

[Maassoft]

I think this might be caused by the install location, which seems to be the system folder of Windows. I don't think it's a good idea to install the app there, or did you not do this?
Btw, you can ignore the paths with my username, these are useful for debugging purposes (they point to the source files on the development machine, the application doesn't need them).

[bel57]

Hey there, thanks for looking into it.
I didn't do anything. I used to update the software manually via github releases but then when you added the auto updater I left the tool do the job. There is no such exe in System32, hence the bug. Something wrong with the new code in the latest build.
Here are the files location:

EDIT: Nevermind, it looks like I now have the app installed twice? It switched from my custom location C:\Users\Bel\ColorControl\ColorControl.exe to C:\Windows\System32\config\systemprofile\AppData\Roaming\Maassoft\ColorControl\ColorControl\ColorControl.exe for some reason. That's the work of your autoupdater, I didn't choose to install it there. I didn't even know such directory existed.
Is that normal that the autoupdater didn't follow the existing path and created a new entry? 😅

EDIT2: So I've done some troubleshooting on my end. I deleted the files in System32 Roaming.
Then ran the ColorControl exe from my user location. It asked me for elevation and to install the service.
I closed the app and rerun it. Same error as before. Closed and relaunched: works fine again (from the same shortcut to my location). I don't understand why the service is stuffing that System32 directory, it is necessary for the service to run? That's a new behavior. Can you reproduce that?

Here's what it looks like after the cleaning:

[Maassoft]

The service is responsible for downloading the new update and updating the files in the location where it is installed, hence you're seeing the files there (it unzips the files there, before copying them).
But maybe your scheduled task isn't configured properly and the "Start in" location is empty or wrong. It should contain the directory the app is installed into (in your case C:\Users\Bel\ColorControl):

You can also just uncheck/check "Automatically start after login" and it should fix the location.
I've just tested an update from earlier 9.x version to 9.4 in a virtual W11 environment and it is working as it should there.

[bel57]

Ok so I unchecked/checked that setting and the task looks the same as yours.

HOWEVER closing the program and running it from my user directory still throws the very same error:

I've narrowed down the error. It's only happening on launch when I fire the exe from the start menu (Startisback).
When I launch it from windows explorer or a shortcut on my desktop, it works fine.

Why all the at Microsoft.Extensions.DependencyInjection.ServiceLookup and at ColorControl.Program.Main errors?
Btw that's new behavior, I've always launched CC from shortcut and from Start menu.

[Maassoft]

Ahh, so you're starting CC from a custom shortcut? Maybe the "Start in" field is empty, so the working directory is probably C:\Windows\system32 then. Be sure to fill in the field like below (in your case C:\Users\Bel\ColorControl):

If I leave it empty I get the same error. It is possible the behavior changed and I think I could change this by always looking at the location of ColorControl.exe and not being dependent on what Windows provides.

[bel57]

My shortcut already has that field filed in, no problem. It's when launching the exe directly from Start Menu that I get the error. I guess there's some argument missing so the exe (and not shortcut) launched from Start menu search is trying to launch from System32. Not a big deal but that could be worth investigating as it's a new behavior. Thanks again for looking into it.

[BoredErica]

When I try to open ColorControl in any way but going to the folder and double clicking, I get the same error. This includes VBS or AHK script. EG:
run C:\Program Files (x86)\ColorControl\ColorControl.exe

causes an error message.