Fix insertText: deprecation: switch to insertText:replacementRange:

All 6 remaining call sites (5 in NSTextView+Autocomplete.m, 1 in
MPDocument.m) were plain 'insert at wherever the cursor/selection
currently is' cases, immediately adjacent in every file to other calls
that already use -insertText:replacementRange:. Converted each to the
same 2-arg NSTextInputClient method, passing NSMakeRange(NSNotFound, 0) --
Apple's documented sentinel meaning 'use the current selection, or the
marked (IME composition) range if there is one', which is exactly what
the deprecated 1-arg -insertText: did. This preserves IME/marked-text
behavior correctly, which plain self.selectedRange would not have during
active composition (this file already special-cases marked text
elsewhere, e.g. hasMarkedText in completeMatchingCharacterForText:atLocation:).

Author: robertobissanti

MacDown/Code/Document/MPDocument.m

@@ -1516,7 +1516,12 @@ - (IBAction)insertNewParagraph:(id)sender
     if (location == newlineBefore + 1 && location == newlineAfter)
         [self.editor insertNewline:self];
     else
-        [self.editor insertText:@"\n\n"];
+        // NSMakeRange(NSNotFound, 0) is Apple's documented sentinel for
+        // -insertText:replacementRange: meaning "use the current selection,
+        // or the marked (IME composition) range if there is one" -- the
+        // same behavior the deprecated 1-arg -insertText: had.
+        [self.editor insertText:@"\n\n"
+               replacementRange:NSMakeRange(NSNotFound, 0)];
 }
 
 - (IBAction)setEditorOneQuarter:(id)sender

MacDown/Code/Extension/NSTextView+Autocomplete.m

@@ -93,7 +93,12 @@ - (void)insertSpacesForTab
     NSUInteger offset = (currentLocation - p - 1) % 4;
     if (offset)
         spaces = [spaces substringFromIndex:offset];
-    [self insertText:spaces];
+    // NSMakeRange(NSNotFound, 0) is Apple's documented sentinel for
+    // -insertText:replacementRange: meaning "use the current selection, or
+    // the marked (IME composition) range if there is one" -- the same
+    // behavior the deprecated 1-arg -insertText: had. Every other call in
+    // this file already uses the 2-arg form; these were the stragglers.
+    [self insertText:spaces replacementRange:NSMakeRange(NSNotFound, 0)];
 }
 
 - (BOOL)completeMatchingCharactersForTextInRange:(NSRange)range
@@ -583,7 +588,7 @@ - (BOOL)completeNextListItem:(BOOL)autoIncrement
     if (contentLength > location + t.length
             && [[content substringWithRange:r] isEqualToString:t])
     {
-        [self insertText:indent];
+        [self insertText:indent replacementRange:NSMakeRange(NSNotFound, 0)];
         return YES;
     }
 
@@ -598,7 +603,7 @@ - (BOOL)completeNextListItem:(BOOL)autoIncrement
     // Insert completion for normal cases.
     if (t.length)
         it = [NSString stringWithFormat:@"%@ ", it];
-    [self insertText:it];
+    [self insertText:it replacementRange:NSMakeRange(NSNotFound, 0)];
     return YES;
 }
 
@@ -639,7 +644,7 @@ - (BOOL)completeNextBlockquoteLine
     }
 
     // Insert completion.
-    [self insertText:markers];
+    [self insertText:markers replacementRange:NSMakeRange(NSNotFound, 0)];
     return YES;
 }
 
@@ -658,7 +663,8 @@ - (BOOL)completeNextIndentedLine
 
     [self insertNewline:self];
     NSRange indentRange = NSMakeRange(start, end - start);
-    [self insertText:[content substringWithRange:indentRange]];
+    [self insertText:[content substringWithRange:indentRange]
+     replacementRange:NSMakeRange(NSNotFound, 0)];
     return YES;
 }