fix(projects): write attachments to mounted uploads volume#1
Merged
MacJediWizard merged 2 commits intomainfrom Apr 30, 2026
Merged
fix(projects): write attachments to mounted uploads volume#1MacJediWizard merged 2 commits intomainfrom
MacJediWizard merged 2 commits intomainfrom
Conversation
The upload handler joined current_app.root_path + '..' + 'uploads/...', which resolved to /app/uploads — outside the mounted volume and owned by root, causing PermissionError on every upload. Point UPLOAD_FOLDER at the existing static/uploads tree (mounted as time_app_uploads volume), matching the convention used by invoices.py and quotes.py.
❌ CI Test ResultsOverall Status: 2 test suite(s) failed Test Results: 0/7 passed Test Suites:
Commit: 583041c |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PermissionError on every project attachment upload.
UPLOAD_FOLDER='uploads/project_attachments'joined withcurrent_app.root_path='/app/app'and'..'resolves to/app/uploads, which is root-owned and outside the mountedapp_uploadsvolume.Fix
Change
UPLOAD_FOLDERtoapp/static/uploads/project_attachments, matching the convention used byinvoices.pyandquotes.py(quote_images). The resolved path becomes/app/app/static/uploads/project_attachments, inside the mounted volume.Download/delete handlers use the same join pattern, so DB-stored paths stay consistent. Zero existing rows in
project_attachmentsso no data migration needed.Also in this PR
Drops Docker Hub publish from
cd-release.yml(this fork only publishes to GHCR — Docker Hub creds aren't configured).Out of scope (follow-up)
app/routes/quotes.py:1120(quote_attachments) has the identical bug.