Adopt streaming in Demo app #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any plan to include this? |
Contributor
Author
|
@rotemdoron I do. Ultimately I defer to @Krivoblotsky |
Contributor
|
I’m ok to merge it into the streaming branch, however, I’m gonna run more tests before merging streaming branch itself to handle some corner cases. |
wangqi
pushed a commit
to wangqi/OpenAI
that referenced
this pull request
Feb 18, 2025
Adopt streaming in Demo app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adopt streaming in demo app, and add a model switcher between gpt3 and 4 models.
DemoAppStreaming.mov
Why
Demo app will be broken if this doesn't come in. Also I think this is how people want to use the API primarily.
Affected Areas
Demo app.