Add models example to Demo app #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJBen
approved these changes
Apr 23, 2023
Krivoblotsky
approved these changes
Apr 24, 2023
wangqi
pushed a commit
to wangqi/OpenAI
that referenced
this pull request
Feb 18, 2025
Add models example to Demo app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
DemoApp Project
• Adds support for listing all available Models (but not yet specific Model requests; TBD placeholder view for now) [id's only, so could be a String array instead, but I expect to add ownership, etc, to the cell in the form of an icon maybe]
• Added a "Misc" tab so other trivial examples can go there as well
• Added a
MiscStoreobject which mimicsChatStore– I don't have a ton of SwiftUI experience so this may not be needed; may be other ways to get the API token for this use case• Some formatting consistency improvements in DemoApp
OpenAI Project
•
ModelResultconforms toIdentifiableso it can be used in SwiftUI List (this may not be the best place for it)Why
Should help with choosing a model for chat which already has an example
Affected Areas
Enhancement only
Improvements
•
Modelbeing an enum with a "localized title" computed property could make it look more presentable in the list – unsupported models could be done like.other("gpt-99")without a formatted title