docs: document bot-authored PR gates and semantic-pr-title trigger#37
Merged
Conversation
Describe two related behaviors that affect release-please and other bot-authored PRs: 1. The first-time-contributor approval gate holds workflow runs with conclusion action_required until a maintainer clicks "Approve and run workflows." This is the intended posture for a public infra module — loosening the gate would auto-run workflows on any stranger's first PR, which is too permissive. 2. GitHub silently suppresses pull_request_target for PRs authored by GitHub App installations. That is why semantic-pr-title.yml was switched from pull_request_target to pull_request in the companion CI change — the previous trigger meant release PRs accumulated with a permanently-missing required check. Add a dedicated top-level section walking through the full release-PR lifecycle (unlock workflows → checks run → bypass merge past skipped go-test and missing non-bot approval) so the two maintainer actions per release are documented and audited behavior rather than undocumented friction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
leonardosul
force-pushed
the
docs/bot-pr-gates
branch
from
fde4d1d to
186273b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conclusion: action_requireduntil a maintainer clicks Approve and run workflowssemantic-pr-title.ymlusespull_requestinstead ofpull_request_target: GitHub silently suppressespull_request_targetfor PRs authored by GitHub App installations, which is why every release-please PR in this repo's history accumulated with a missing required checkCompanion PR
Pair with #36, which makes the
semantic-pr-title.ymltrigger change. This doc PR describes the final state; both should merge together.What's new in the doc
semantic-pr-title.ymlpull_request_target" bullet in the Semantic PR Title workflow detailpull_request_targetsuppression and a step-by-step of what to expect on a release PRTest plan
--strictbuild passes locally (verified)🤖 Generated with Claude Code