fix: include on_recall_mix in ACE and RLM DEFAULT_HOOK_ENTRY#25
Merged
timeleft-- merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: include on_recall_mix in ACE and RLM DEFAULT_HOOK_ENTRY#25timeleft-- merged 1 commit intomainfrom
timeleft-- merged 1 commit intomainfrom
Conversation
The on_recall_mix lifecycle hook was implemented in both protocols (delegating to on_recall) but missing from their DEFAULT_HOOK_ENTRY dicts. This meant `fava-trails ace setup --write` and `fava-trails rlm setup --write` would generate config.yaml entries without the on_recall_mix hook point, silently omitting cross-trail recall reranking/sorting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_recall_mixtoDEFAULT_HOOK_ENTRY["points"]in bothfava_trails.protocols.aceandfava_trails.protocols.rlmon_recall_mix(delegating toon_recall), but the CLI setup commands (fava-trails ace setup --write/fava-trails rlm setup --write) would generate config without itTest plan
uv run pytest tests/test_cli.py -v)fava-trails ace setupand verify output includeson_recall_mixfava-trails rlm setupand verify output includeson_recall_mix🤖 Generated with Claude Code