Kernel/helper fixes and a few new features#160
Merged
westonslaughter merged 5 commits intoMacroSHEDS:masterfrom Oct 14, 2022
Merged
Kernel/helper fixes and a few new features#160westonslaughter merged 5 commits intoMacroSHEDS:masterfrom
westonslaughter merged 5 commits intoMacroSHEDS:masterfrom
Conversation
westonslaughter
approved these changes
Oct 14, 2022
Contributor
There was a problem hiding this comment.
looks great, thanks for the detailed heads up on your changes! and for all of your close review of the pkernels lately -- I believe I understand the write/return distinction, and certainly do practically, I will look out for that especially as the data team approaches munging.
vlahm
pushed a commit
to vlahm/macrosheds_data_processing
that referenced
this pull request
Jul 18, 2023
Kernel/helper fixes and a few new features
vlahm
pushed a commit
to vlahm/macrosheds_data_processing
that referenced
this pull request
Dec 5, 2023
Kernel/helper fixes and a few new features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@westonslaughter, take a look at the changes to any of the Niwot stream_chemistry munge kernels (process_1_108 is a good example). This domain flags measurements that are below detection limit by inserting e.g. "<0.02" into the data columns. I noticed Spencer was referring to every instance of "<0.XX" individually, which is not future proof, so now there's a wildcard that represents any numeric value, including a possible decimal point.
There were two other issues in these kernels. One inconsequential but confusing to potential copy/pasters:
variable_flags_dirty = 'dirty')wasn't doing anything here.More importantly, I forgot to insertd <- qc_hdetlim_and_uncert(d, prodname_ms = prodname_ms)into these kernels! So BDL datapoints weren't being replaced by their half-detection-limit values.Nvm re:
qc_hdetlim_and_uncert! Forgot I added this to the munge engines, so it's not needed inside kernels in most cases. Though note it is required in kernels that write their output, rather than returning it.ftgrep .R qc_hdetlimto see where it's used.