mg7: fix gogo generation CI crash + add red mg7 xsec tracker#20
Merged
oliviermattelaer merged 1 commit intoJun 25, 2026
Merged
Conversation
test_generation_from_file_1 drives generate_events from the input file tests/input_files/test_mssm_generation, which used a bare `output` that now defaults to mg7. mg7 has no event-generation pipeline for this MSSM p p > go go process, so the run crashed. Pin the input file to `output madevent` (the MadEvent reference cross-sections / banner / LHE assertions are MadEvent-specific), matching the branch-wide convention for generate_events tests. Add the missing mg7 counterpart as an explicit (intentionally red) tracker: test_generation_from_file_1_mg7 runs the full mg7 (madspace) pipeline for p p > go go and pins the cross-section to the madevent reference (4.541638 pb, run_01 of test_generation_from_file_1). standalone_mg7 already reproduces the per-flavor |M|^2 (test_standalone_mg7_mssm_gogo), but full mg7 event generation for merged-flavor processes is not wired up yet (the madspace integrator does not produce the cross-section, cf. the SM tracker test_madevent_merged_flavor_uq_mg7). Left undecorated so the gap stays visible. New CI job acceptancetest_mg7_mssm_gogo_xsec runs it (self-skips without the madspace + LHAPDF stack). Also refresh the stale acceptancetest_mg7_mssm_gogo comment: mg7 no longer refuses MSSM gogo with InvalidCmd; it generates the matrix element and is checked per-flavor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oliviermattelaer
merged commit 1c6d88a
into
claude/mg7-flv-single-leg
308 of 313 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI crash in
test_generation_from_file_1and adds the missing mg7 event-generation coverage for MSSMp p > go goas an explicit (intentionally red) tracker.Root cause of the crash
test_generation_from_file_1drivesgenerate_eventsfrom the input filetests/input_files/test_mssm_generation, which used a bareoutput— and bareoutputnow defaults to mg7 (check_output(..., default='mg7')). mg7 has no event-generation pipeline for this MSSM merged-flavor process, so the run crashed. The test's assertions (cross-sections 4.541638 / 4.41887317, bannerptheavy, LHE parsing) are MadEvent-specific, so the test belongs to the MadEvent path.Fix: pin the input file to
output madevent, matching the branch-wide convention for generate_events tests.New mg7 tracker
The Massaro merged-flavor commits made standalone_mg7 reproduce the per-flavor |M|^2 for
p p > go go(test_standalone_mg7_mssm_gogo), but full mg7 event generation for merged-flavor processes is not wired up yet — the madspace integrator does not produce the cross-section (cf. the existing SM trackertest_madevent_merged_flavor_uq_mg7).test_generation_from_file_1_mg7runs the full mg7 (madspace) pipeline forp p > go goand pins the cross-section to the madevent reference (4.541638 pb). Left undecorated (not @expectedfailure) so the gap stays visible, matching the other red mg7 trackers. Self-skips without the madspace + LHAPDF(NNPDF23) stack.acceptancetest_mg7_mssm_gogo_xsecruns it.Also
acceptancetest_mg7_mssm_gogojob comment (mg7 no longer refuses MSSM gogo with InvalidCmd — it generates the matrix element and is checked per-flavor).Expected CI state
acceptancetest_mg7_mssm_gogo_xsecis expected to be red until the mg7 integrator handles merged-flavorp p > go go. This is intentional — keeping the missing-feature gap visible.🤖 Generated with Claude Code