refactor: use message utils factory functions#31
Open
SimFG wants to merge 1 commit intoMagicCube:mainfrom
Open
refactor: use message utils factory functions#31SimFG wants to merge 1 commit intoMagicCube:mainfrom
SimFG wants to merge 1 commit intoMagicCube:mainfrom
Conversation
…t construction Replace all manual message and content part construction with factory functions from @/foundation/messages/utils: - Content parts: createTextContent, createThinkingContent (with providerData), createToolUseContent, createToolResultContent - Messages: createSystemMessage, createUserMessage, createAssistantMessage, createAssistantMessageWithContent (now supports usage/streaming options), createToolMessage - Adapter helpers: anthropicTextBlock/ThinkingBlock/ToolUseBlock/etc. and openaiToolCall/ToolMessage/AssistantMessage for third-party SDK types ThinkingContent now has an optional providerData field for provider-specific metadata (e.g. Anthropic _anthropicSignature), replacing the previous as-unknown-as-Record hack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: use message utils factory functions instead of inline object construction
Replace all manual message and content part construction with factory functions from @/foundation/messages/utils:
ThinkingContent now has an optional providerData field for provider-specific metadata (e.g. Anthropic _anthropicSignature), replacing the previous as-unknown-as-Record hack.