Fix #47#48
Merged
MagicJinn merged 2 commits intoMagicJinn:mainfrom Mar 29, 2026
Merged
Conversation
Owner
|
Thank you for the fix! I've tested it, and fixed some more error messages that appeared in the log when using floo powder.
Well, the entire network side of Quantum Things was recently rewritten in a PR, and some things have seemingly been lost in translation. The original file did indeed have the Client Only tag. |
Contributor
Author
|
@MagicJinn You've yet again removed the SideOnly annotation... |
Owner
|
Yes, but now it's handled by the proxy system. Before, while it fixed the crash, it would still spam around 10 errors in the console. Now, it doesn't crash, and doesn't spam errors. It has something to do with client class references still being present in server files, even if it doesn't outright crash the game. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47 by readding the
@SideOnly(Side.CLIENT)annotation.Unrelated, but why was this removed in first place?