clarify that public folder requires node_helper.js#362
Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom Feb 26, 2026
Merged
Conversation
rejas
approved these changes
Feb 26, 2026
khassel
added a commit
that referenced
this pull request
Apr 1, 2026
* docs: improve autostart guide with user systemd service for full Electron UI (#345) * Update autostart.md Improve autostart documentation: add user systemd service for full Electron UI with logging and environment variables * Update autostart.md docs: address PR feedback — clarify display server and disable logging by default * Update autostart.md docs: verified the environment inherited by systemd --user, ensured DISPLAY=:0 and WAYLAND_DISPLAY=wayland-0 is set up automatically * Update autostart.md docs: updated Troubleshooting section * clarify systemd service behavior + minor changes - Add platform note: Clarify guide is for Raspberry Pi OS Desktop - Fix typo: WAYLAND_DIAPLAY → WAYLAND_DISPLAY - Fix misleading comment: System services start on boot, not after user login - Remove trailing whitespace and newline --------- Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> * style: set carbon ads background color to inherit (#350) * location of default modules changed (#353) see MagicMirrorOrg/MagicMirror#4019 * move custom.css from css to config (#354) * update variables in config * add secrets.md * fix typo * add missing " * node_modules/vitepress/types/default-theme.d.ts * apply Prettier formatting * handle cspell issues * add weatherapi options to weather module configuration (#359) * docs(compliments): clarify remoteFile path resolution and limitations (#360) * docs: correct loaded() - server-side only, not a client-side hook (#361) Document that loaded() belongs to node_helper, not Module. Add async/Promise support to the start() docs as the correct way to handle asynchronous module initialization. * docs: clarify that public folder requires node_helper.js (#362) * docs: explain physical concept and hardware scope on landing page (#365) Add a short paragraph to index.md that explains what a MagicMirror physically is, clarifies that this documentation covers the software side only, and points newcomers to the community showcase for hardware build inspiration. Closes MagicMirrorOrg/MagicMirror#3282 * add weather templates (#366) * weather: add themes example * calendar: align showEnd and dateEndFormat defaults (#368) * fix failing tests --------- Co-authored-by: Github Actions <actions@github.com> Co-authored-by: Станислав <52878917+vectorman115@users.noreply.github.com> Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com> Co-authored-by: veeck <gitkraken@veeck.de> Co-authored-by: sam detweiler <sdetweil@gmail.com> Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module structure docs state that files in
modulename/publicare accessible via/modulename/filename.ext, but don't mention that this only works when the module has anode_helper.js.The static route is registered in
setExpressApp()(node_helper.js), which is only called for modules that have a node helper. Modules without one never get theirpublicfolder served — resulting in 404s that are hard to debug.Context
This came up as a question on Discord — a user placed images in
modules/my-module/publicand got 404s.