test(calendar): fix hardcoded date in event shape test#4055
Merged
khassel merged 1 commit intoMagicMirrorOrg:developfrom Mar 11, 2026
Merged
test(calendar): fix hardcoded date in event shape test#4055khassel merged 1 commit intoMagicMirrorOrg:developfrom
khassel merged 1 commit intoMagicMirrorOrg:developfrom
Conversation
Replace the fixed 2026-03-10 date with a relative date (tomorrow) so the test doesn't silently fail once the date has passed. firstYear is now derived dynamically from the generated start date.
khassel
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into #4053 I noticed that one of the calendar tests had stopped working. The cause was simple: the test had
2026-03-10hardcoded, and since that date is now in the past, the event was silently filtered out byincludePastEvents: false.Instead of bumping the date to some future value (which would only delay the same problem), I made it relative so it always lies in the future.
Command to test: