Skip to content

ci(codeql): also scan develop branch on push and PR#4086

Merged
rejas merged 1 commit intoMagicMirrorOrg:developfrom
KristjanESPERANTO:codeql
Apr 4, 2026
Merged

ci(codeql): also scan develop branch on push and PR#4086
rejas merged 1 commit intoMagicMirrorOrg:developfrom
KristjanESPERANTO:codeql

Conversation

@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator

@KristjanESPERANTO KristjanESPERANTO commented Apr 3, 2026

Previously only master was scanned via the default CodeQL setup. Since development happens on develop, this PR replaces the default setup with a custom workflow that covers both branches. This gives an overview of the security status across the current release (master) and the development branch (develop).

As a result we should also see issues in the develop branch here: https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning

@KristjanESPERANTO KristjanESPERANTO marked this pull request as draft April 3, 2026 17:44
@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator Author

Oh, I'm afraid it only works with the default branch... :-( I'll look into it.

@KristjanESPERANTO KristjanESPERANTO force-pushed the codeql branch 2 times, most recently from 77aefc5 to 99540e7 Compare April 4, 2026 13:06
Previously only master was scanned via the default CodeQL setup.
Since development happens on develop, this PR replaces the default
setup with a custom workflow that covers both branches. This gives
an overview of the security status across the current release
(master) and the development branch (develop).
@KristjanESPERANTO KristjanESPERANTO changed the title ci: add CodeQL workflow targeting develop branch ci(codeql): also scan develop branch on push and PR Apr 4, 2026
@KristjanESPERANTO
Copy link
Copy Markdown
Collaborator Author

KristjanESPERANTO commented Apr 4, 2026

It works now after disabling the default CodeQL setup.

@KristjanESPERANTO KristjanESPERANTO marked this pull request as ready for review April 4, 2026 13:40
@rejas rejas merged commit f079324 into MagicMirrorOrg:develop Apr 4, 2026
12 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the codeql branch April 4, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants