fix(weather): avoid loading state after reconnect#4121
Open
KristjanESPERANTO wants to merge 1 commit intoMagicMirrorOrg:developfrom
Open
fix(weather): avoid loading state after reconnect#4121KristjanESPERANTO wants to merge 1 commit intoMagicMirrorOrg:developfrom
KristjanESPERANTO wants to merge 1 commit intoMagicMirrorOrg:developfrom
Conversation
Collaborator
|
We are always providing server mode functionality. |
Collaborator
Author
|
Yes, but what’s your point in the context of this PR? |
Collaborator
|
You said applies in server mode. We always have server. Even the electron launches as client |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client reconnects while the backend is still in its rate-limit protection phase, the weather module has no data to show and stays on
Loading...until the next scheduled API call. This mainly affects server mode setups, where the server keeps running while a remote client temporarily loses its connection and reloads. It was raised in the forum and is worthy of a fix to improve the user experience.With this PR the node helper caches the last successful
WEATHER_DATApayload per instance and replays it immediately on reconnect. The client gets its last known state right away instead of waiting for the next fetch. The cache is cleaned up when the provider stops.Tests are included to cover reconnect with and without cached data, and the cleanup path.