fix port value mismatch in create_server#8
Closed
claws wants to merge 1 commit into
Closed
Conversation
Member
|
LGTM. Will merge later today. |
Member
|
Merged by hand. I've also published uvloop v0.4.11 with your fix in. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request provides a fix for the issue outlined in #7.
The
asyncioloop.create_servermethod acceptsport=Noneas a valid argument butuvloopraises an exception. To approach true drop in replacement parityuvloopshould ideally allow this argument and create an ephemeral port the same asasynciodoes.This change also provides a unit test to verify the functionality.