Skip to content

Conversation

@Naupio
Copy link
Contributor

@Naupio Naupio commented Aug 29, 2022

link issue #918

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 30.254% when pulling d8c3b46 on Naupio:fix_smart_contract_nil_field_update into fae6c6e on Magickbase:godwoken-v1-testnet-prod.

@Naupio Naupio changed the title Fix smart contract nil field update Fix smart contract nil field update replace exist value Aug 30, 2022
@Naupio Naupio changed the title Fix smart contract nil field update replace exist value Fix smart contract nil field update replace existed value Aug 30, 2022
@Naupio
Copy link
Contributor Author

Naupio commented Aug 30, 2022

if deployment tx hash not found in polyjuice table, trigger verify_and_update_from_sourcify api will use nil replace existed value in smart contract, its not expect behavior, solve it with filtering nil params when updating @Keith-CY @zmcNotafraid

@Naupio Naupio changed the title Fix smart contract nil field update replace existed value BUG: Hot Fix smart contract nil field update replace existed value Aug 30, 2022
@Naupio Naupio force-pushed the fix_smart_contract_nil_field_update branch from d8c3b46 to 520764d Compare August 30, 2022 13:10
@Naupio Naupio merged commit 59de893 into Magickbase:godwoken-v1-testnet-prod Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants