Refactor PromptLayer API integration to include base URL parameter #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abubakarsohail
force-pushed
the
abubakar/lac-647-python-sdk
branch
2 times, most recently
from
9f04c29 to
0ed5fbb
Compare
sacha-promptlayer
approved these changes
Oct 22, 2025
Contributor
sacha-promptlayer
left a comment
sacha-promptlayer
left a comment
There was a problem hiding this comment.
Looks good. The one thing I don't understand is that we no longer patching the base_url but now loading it from env in the tests? Wouldn't we want a consistent base_url to test with? or it actually hitting the endpoint?
Contributor
Author
|
Good catch. For tests, we do not to read from environment. The endpoints hit a hard coded localhost url. I'll update the test. |
abubakarsohail
force-pushed
the
abubakar/lac-647-python-sdk
branch
9 times, most recently
from
5112ba4 to
440514f
Compare
abubakarsohail
force-pushed
the
abubakar/lac-647-python-sdk
branch
from
440514f to
e846ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the PromptLayer API integration by adding a base URL parameter, allowing for more flexible API endpoint configurations. Update related functions and tests to accommodate this new parameter.