Skip to content

Conversation

@Apricot-S
Copy link
Collaborator

#55

  • Migrate development tools to uv and Ruff
  • Replace setup.py with pyproject.toml for modern project configuration

Ruff settings were matched to the existing tool settings as much as possible.

Some settings in pyproject.toml are not compatible with Python 3.8, but this will not be a problem in the end because we will drop support for Python 3.8 in a later PR.

@Apricot-S Apricot-S requested a review from Nihisil May 6, 2025 09:39
@Nihisil
Copy link
Contributor

Nihisil commented May 6, 2025

@Apricot-S thank you for your contribution

can you please check the failing GH actions? GH workflows need to be updated too

@Apricot-S
Copy link
Collaborator Author

@Nihisil
Thank you for your feedback! As we continue refining the project, we are considering different approaches to handle the CI failures. Here are the three possible options:

  1. Submit PRs progressively as planned

    • Some intermediate PRs will cause CI failures, but this is expected and will be resolved in the final step.
    • This allows for a structured and manageable review process.
  2. Submit a single PR including all changes

    • This would ensure CI success but would bundle multiple modifications together, making the review process more complex.
    • Might be harder to track specific changes and fixes individually.
  3. Rework commits so that CI passes from the beginning

    • Ensures CI stability throughout but requires significant additional time and effort.
    • Could slow down the overall progress of the migration.

Which approach do you think would be best moving forward? Let me know your thoughts!

@Nihisil Nihisil merged commit 1f32c44 into MahjongRepository:master May 7, 2025
1 of 2 checks passed
@Nihisil
Copy link
Contributor

Nihisil commented May 7, 2025

If you plan to fix CI in the next PRs, I do not mind handling these errors later.

I also added you as a contributor to this project, so you can create branches here instead of forks to make your life a little easier

@Apricot-S Apricot-S deleted the chore/uv-ruff branch May 7, 2025 21:54
@Apricot-S Apricot-S restored the chore/uv-ruff branch May 8, 2025 13:09
@Apricot-S Apricot-S deleted the chore/uv-ruff branch May 8, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants