Use el.parentNode.removeChild(el) instead of el.remove() for IE < 11#21
Merged
Fetz merged 1 commit intoMailOnline:masterfrom Oct 26, 2016
Merged
Use el.parentNode.removeChild(el) instead of el.remove() for IE < 11#21Fetz merged 1 commit intoMailOnline:masterfrom
Fetz merged 1 commit intoMailOnline:masterfrom
Conversation
Contributor
|
👍 |
iq-dot
pushed a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
* removed playlist file | when no videos returned, returns empty array rather than predefined playlist * Some linting: using const rather than let where variable is not reassigned | deleted some unused variables * player should only render when videos are returned * console logging when no videos are found | Call for videos is made in constructor on initial state * Added isLoading param to state, which turns to false after video is loaded via setVideos * removed conditional rendering, for now. * video doesn't display when loading, and player dismounts if no video loaded * removed this.state.noVideos | removed skipcache=true from endpoint * Now getting videos in App rather than player * HandleScroll only running if video is loaded * minor changes: replaced uat with api, change in handleScroll function, passing container as prop to Player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue 20.
Please merge this patch if you feel happy. Thanks much.