Do not use functions as keys in timeouts hash#22
Merged
Fetz merged 2 commits intoMailOnline:masterfrom Oct 26, 2016
diggabyte:fix-clear-timeouts
Merged
Do not use functions as keys in timeouts hash#22Fetz merged 2 commits intoMailOnline:masterfrom diggabyte:fix-clear-timeouts
Fetz merged 2 commits intoMailOnline:masterfrom
diggabyte:fix-clear-timeouts
Conversation
Contributor
|
👍 |
iq-dot
added a commit
to iq-dot/VPAIDHTML5Client
that referenced
this pull request
Jul 28, 2017
* Added a system to configure on a per client basis any page selectors our player can hook onto * Added telegraph article body detection and attaching to it * Add telegraph selector detection. * Separate client configuration into a separate file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeoutsobject is using callback functions as the keys in the hash. The javascript interpretor invokes.toString()on the callback function because objects cannot be used as keys.This means you end up with a key like so:
The problem is that this is NOT a unique key, which can causes key collisions in the
timeoutshash.My proposed fix is to directly clear the timeout ID (which is unique) upon success.
Tests are passing for this change set.
On a side-note, it seems that the bin output does not match what is checked into master. I've updated those with this pull request as well.